Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable no explicit any #40

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

calirvine
Copy link
Contributor

Removed last remaining explicit any.

I would recommend dropping prop-types as a dependency and using typescript for the components as well, as the api is pretty verbose and not as expressive. On top of that, PropTypes perform a runtime typecheck, but ideally runtime type checking should be happening at the API boundaries, allowing us to trust typescript throughout the rest of the application.

Because PropTypes performs runtime type checking, this PR should not be treated as type level only changes.

Closes #13

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1d743a1) 72.88% compared to head (e66f1be) 72.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
+ Coverage   72.88%   72.96%   +0.08%     
==========================================
  Files          18       18              
  Lines        1973     1979       +6     
  Branches      119      119              
==========================================
+ Hits         1438     1444       +6     
  Misses        529      529              
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benvinegar benvinegar merged commit ebee272 into benvinegar:main Feb 8, 2024
3 checks passed
@benvinegar
Copy link
Owner

Awesome! (I'll try to keep the prop-types stuff in mind – but I'm probably more focused on adding table-stakes missing features vs. achieving full static checking enlightenment). I do have production visibility now with Sentry (#32).

benvinegar pushed a commit that referenced this pull request Dec 20, 2024
* Clean up remaining explicit any

* Turn on warn for no-explicit-any

---------

Co-authored-by: Cal Irvine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement missing TypeScript types
2 participants