Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix table rows on Firefox #45

Merged
merged 1 commit into from
Feb 11, 2024

Conversation

anurag-roy
Copy link
Contributor

Fix #42

Removed the extra relative classes, which were causing the issue on FireFox.

@benvinegar
Copy link
Owner

Ah, yeah I did briefly debug this and saw how relative was being propagated and couldn't figure out from where. Oops.

Copy link

codecov bot commented Feb 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aa97e2d) 73.51% compared to head (7d39905) 73.51%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #45   +/-   ##
=======================================
  Coverage   73.51%   73.51%           
=======================================
  Files          18       18           
  Lines        2016     2016           
  Branches      129      129           
=======================================
  Hits         1482     1482           
  Misses        528      528           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benvinegar benvinegar merged commit 64fb75a into benvinegar:main Feb 11, 2024
3 checks passed
benvinegar pushed a commit that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table card missing row borders below fill area in Firefox
2 participants