Render views + visitors in table card by path #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
==========================================
+ Coverage 72.69% 73.65% +0.96%
==========================================
Files 18 18
Lines 2036 2133 +97
Branches 129 142 +13
==========================================
+ Hits 1480 1571 +91
- Misses 550 556 +6
Partials 6 6 ☔ View full report in Codecov by Sentry. |
benvinegar
changed the title
benvinegar
added a commit
that referenced
this pull request
Dec 20, 2024
* Render views + visitors in table card by path * Sort results by visitors * Views, not visits * Put common count accumulation code into a helper fn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new method,
getAllCountsByColumn, which returnsvisits,views, andvisitorsfor a given column (e.g. path, referrer, etc). Then modifies the "Counts by Path" table card to fetch that data and render multiple columns.I decided to sort by visitors, because that's usually what I care about, but it could be views instead.
Fixes #12