Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark mode #93

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add dark mode #93

wants to merge 1 commit into from

Conversation

qwtel
Copy link

@qwtel qwtel commented Aug 28, 2024

Added dark mode based on the (wip?) support that was already part of the repo.

Tweaked the colors a bit based on my own taste.

Added missing dark mode support to the chart, bars and some other places.

There is no toggle, it just follows prefers-color-scheme.

Also includes an inverted version of the counterscale graphic for the landing page.

Screenshot:

Screenshot 2024-08-28 at 16 53 35

@benvinegar
Copy link
Owner

This is awesome!

@benvinegar
Copy link
Owner

Apologies for the slow response – I'd like an opportunity to just play with this and do some testing before merging.

@qwtel
Copy link
Author

qwtel commented Sep 5, 2024

No worries, I mostly just wanted this to be visible to someone searching for dark mode.

Btw, I have more improvements on my fork that includes a proper app icon, webapp manifest, and marks many elements as sticky, giving the dashboard a more app-like feel.

Taken together, it makes "Add to Dock" / "Install app" work which gives a native-ish app that looks like this:

Screenshot 2024-09-05 at 15 51 46

@benvinegar
Copy link
Owner

Taken together, it makes "Add to Dock" / "Install app" work which gives a native-ish app that looks like this:

Very cool.


I think my only hesitation on the PR right now is that this applies site-wide, including the landing page, and I don't think this is the look I want to go for.

image

I'm also not sure if I'm capable of maintaining a second "dark" look site-wide that people auto-opt into.

What if we (or I) just added a dark mode toggle in the corner? And we just remember the setting in a cookie.

@stoic-hugo
Copy link
Contributor

The Dark Reader extension suggests a colour scheme that closely matches the current one https://imgur.com/a/qmFuJr1

@benvinegar
Copy link
Owner

@qwtel btw do you have your fork deployed somewhere? I'm curious to try the other enhancements.

(Haven't forgotten about this PR.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants