major refactor #519
major refactor #519
Conversation
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| } | ||
|
|
||
| // This is a modified copy of resource.Builder's mappingFor method. | ||
| func (r *ResourceRepo) mappingFor(resourceOrKindArg string) (*meta.RESTMapping, error) { |
There was a problem hiding this comment.
Method ResourceRepo.mappingFor has 6 return statements (exceeds 4 allowed).
| @@ -57,22 +93,127 @@ | |||
| return builder.Do() | |||
| } | |||
|
|
|||
| func (r *ResourceRepo) ResourceInfos(namespace string, args []string, labelSelector string) ([]*resource.Info, error) { | |||
| func (r *ResourceRepo) Objects(namespace string, args []string, labelSelector string) (Objects, error) { | |||
There was a problem hiding this comment.
exported method ResourceRepo.Objects should have comment or be unexported
| return m["creationTimestamp"] | ||
| } | ||
|
|
||
| func (u Object) Unstructured() *unstructured.Unstructured { |
There was a problem hiding this comment.
exported method Object.Unstructured should have comment or be unexported
| return &unstructured.Unstructured{Object: u} | ||
| } | ||
|
|
||
| type Objects []Object |
There was a problem hiding this comment.
exported type Objects should have comment or be unexported
| } | ||
|
|
||
| func NewResourceRepo(factory util.Factory) ResourceRepo { | ||
| type Object map[string]interface{} |
There was a problem hiding this comment.
exported type Object should have comment or be unexported
|
Code Climate has analyzed commit 1e84d75 and detected 17 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
| return unstructuredObjects, err | ||
| } | ||
|
|
||
| func (r *ResourceRepo) Owners(obj Object) (out Objects, err error) { |
There was a problem hiding this comment.
Method ResourceRepo.Owners has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
| return mapping, nil | ||
| } | ||
|
|
||
| func (r *ResourceRepo) Ingresses(namespace string) (*netv1.IngressList, error) { |
There was a problem hiding this comment.
Similar blocks of code found in 3 locations. Consider refactoring.
| return clientSet.NetworkingV1().Ingresses(namespace).List(context.TODO(), metav1.ListOptions{}) | ||
| } | ||
|
|
||
| func (r *ResourceRepo) Services(namespace string) (*corev1.ServiceList, error) { |
There was a problem hiding this comment.
Similar blocks of code found in 3 locations. Consider refactoring.
| return clientSet.CoreV1().Services(namespace).Get(context.TODO(), name, metav1.GetOptions{}) | ||
| } | ||
|
|
||
| func (r *ResourceRepo) Endpoints(namespace string) (*corev1.EndpointsList, error) { |
There was a problem hiding this comment.
Similar blocks of code found in 3 locations. Consider refactoring.
pkg/input/input.go
Outdated
|
|
||
| return ResourceRepo{ | ||
| func NewResourceRepo(factory util.Factory) *ResourceRepo { |
There was a problem hiding this comment.
exported function NewResourceRepo should have comment or be unexported
|
|
||
| return ResourceRepo{ | ||
| f: factory, | ||
| func NewResourceRepo(factory util.Factory) (*ResourceRepo, error) { |
There was a problem hiding this comment.
exported function NewResourceRepo should have comment or be unexported
| return unstructuredObjects, err | ||
| } | ||
|
|
||
| func (r *ResourceRepo) Owners(obj Object) (out Objects, err error) { |
There was a problem hiding this comment.
exported method ResourceRepo.Owners should have comment or be unexported
| return out, nil | ||
| } | ||
|
|
||
| func (r *ResourceRepo) FirstObject(namespace string, args []string, labelSelector string) (Object, error) { |
There was a problem hiding this comment.
exported method ResourceRepo.FirstObject should have comment or be unexported
| return objects[0], err | ||
| } | ||
|
|
||
| func (r *ResourceRepo) ObjectEvents(u *unstructured.Unstructured) (*corev1.EventList, error) { |
There was a problem hiding this comment.
exported method ResourceRepo.ObjectEvents should have comment or be unexported
| } | ||
|
|
||
| func (r *ResourceRepo) ToRESTMapper() (meta.RESTMapper, error) { | ||
| return r.f.ToRESTMapper() | ||
| func (r *ResourceRepo) DynamicObject(gvr schema.GroupVersionResource, namespace string, name string) (Object, error) { |
There was a problem hiding this comment.
exported method ResourceRepo.DynamicObject should have comment or be unexported
| } | ||
|
|
||
| func (r *ResourceRepo) KubernetesClientSet() (*kubernetes.Clientset, error) { | ||
| return r.f.KubernetesClientSet() | ||
| func (r *ResourceRepo) DynamicObjects(gvr schema.GroupVersionResource, namespace string) (Objects, error) { |
There was a problem hiding this comment.
exported method ResourceRepo.DynamicObjects should have comment or be unexported
| } | ||
|
|
||
| func (r *ResourceRepo) DynamicClient() (dynamic.Interface, error) { | ||
| return r.f.DynamicClient() | ||
| func (r *ResourceRepo) GVRFor(resourceOrKindArg string) (schema.GroupVersionResource, error) { |
There was a problem hiding this comment.
exported method ResourceRepo.GVRFor should have comment or be unexported
| return mapping, nil | ||
| } | ||
|
|
||
| func (r *ResourceRepo) Ingresses(namespace string) (*netv1.IngressList, error) { |
There was a problem hiding this comment.
exported method ResourceRepo.Ingresses should have comment or be unexported
| return r.kubernetesClientSet.NetworkingV1().Ingresses(namespace).List(context.TODO(), metav1.ListOptions{}) | ||
| } | ||
|
|
||
| func (r *ResourceRepo) Services(namespace string) (*corev1.ServiceList, error) { |
There was a problem hiding this comment.
exported method ResourceRepo.Services should have comment or be unexported
| return r.kubernetesClientSet.CoreV1().Services(namespace).List(context.TODO(), metav1.ListOptions{}) | ||
| } | ||
|
|
||
| func (r *ResourceRepo) Service(namespace, name string) (*corev1.Service, error) { |
There was a problem hiding this comment.
exported method ResourceRepo.Service should have comment or be unexported
| return r.kubernetesClientSet.CoreV1().Services(namespace).Get(context.TODO(), name, metav1.GetOptions{}) | ||
| } | ||
|
|
||
| func (r *ResourceRepo) Endpoints(namespace string) (*corev1.EndpointsList, error) { |
There was a problem hiding this comment.
exported method ResourceRepo.Endpoints should have comment or be unexported
| return nodeStatsSummary, err | ||
| } | ||
|
|
||
| func (r *ResourceRepo) NonTerminatedPodsOnTheNode(nodeName string) (Objects, error) { |
There was a problem hiding this comment.
exported method ResourceRepo.NonTerminatedPodsOnTheNode should have comment or be unexported
No description provided.