Create course-based groups. #3509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's just good life advice.
|
@ryanlovett Can you point out the issue this PR corresponds to? Did you create this PR based on the requirement shared by D-Lab folks? |
|
@balajialg This doesn't related to a specific issue, although a nearby one would be #2008. This work is tidying up some of the class resource allocation bits, moving some logic from our custom KubeSpawner into the CanvasAuthenticator. @yuvipanda and I hashed it out in person I think. |
|
Sounds great! Thanks @ryanlovett for all your work with this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn them on for prob140.