Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate data102 hub to have its own image #5054

Merged
merged 7 commits into from
Sep 21, 2023
Merged

Isolate data102 hub to have its own image #5054

merged 7 commits into from
Sep 21, 2023

Conversation

balajialg
Copy link
Contributor

@balajialg balajialg commented Sep 20, 2023

Resolves #5037 and #4953

The new image builds successfully on my local machine. Fingers crossed about CI/CD

Reference for this PR: #4423 , #4852, #5042

This PR needs to get merged once we get the confirmation from the course staff about upgrading to python 3.11 and list of packages installed.

@shaneknapp
Copy link
Contributor

you will also need to add entries in .circleci/config.yml for the image to be built via CI/CD.

@balajialg
Copy link
Contributor Author

balajialg commented Sep 20, 2023

Thanks @shaneknapp! Just added the entry in CircleCI. Let me know if the config changes are correct.

edit: I will look into the yaml issue today evening (once I get free)

.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
@shaneknapp
Copy link
Contributor

you should check to see if they would like the jupyterlab interface by default (which i would strongly recommend). if they do, then you'll need to add the following bits in the singleuser: block in common.yaml:

    defaultUrl: /lab
    extraEnv:
      # Unset NotebookApp from hub/values. Necessary for recent lab versions.
      JUPYTERHUB_SINGLEUSER_APP: "jupyter_server.serverapp.ServerApp"

https://github.com/berkeley-dsep-infra/datahub/blob/staging/deployments/data101/config/common.yaml#L167
https://github.com/berkeley-dsep-infra/datahub/blob/staging/deployments/data100/config/common.yaml#L39

@balajialg
Copy link
Contributor Author

balajialg commented Sep 20, 2023

@shaneknapp Data102's nbgitpuller links launches their assignments in the lab interface by default. In fact, the Data 102 hub currently launches the lab interface directly without the config changes shared above. Is it necessary to add this block given this context? Having said that, I added the required config changes in common.yml and commented out python-mode. Thanks for the recommendations!

Copy link
Collaborator

@ryanlovett ryanlovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor note about jupyterlab being included twice.

@shaneknapp
Copy link
Contributor

@shaneknapp Data102's nbgitpuller links launches their assignments in the lab interface by default. In fact, the Data 102 hub currently launches the lab interface directly without the config changes shared above. Is it necessary to add this block given this context? Having said that, I added the required config changes in common.yml and commented out python-mode. Thanks for the recommendations!

afaik, this is something required by jupyterlab 4... @ryanlovett, @felder and i had to do this for stat159, data100 and data101.

@balajialg
Copy link
Contributor Author

Thanks @ryanlovett for catching the duplicate entry. Fixed it in the latest commit

@balajialg
Copy link
Contributor Author

@shaneknapp Got it. Thanks for the clarification :)

Copy link
Collaborator

@ryanlovett ryanlovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments about probably unneeded packages.

deployments/data102/image/apt.txt Outdated Show resolved Hide resolved
deployments/data102/image/apt.txt Outdated Show resolved Hide resolved
@shaneknapp
Copy link
Contributor

this looks good to merge whenever we get the word from the data102 folks!

@balajialg
Copy link
Contributor Author

balajialg commented Sep 21, 2023

@shaneknapp @ryanlovett Merging this PR to staging as Data 102 folks gave a heads up! They would like to test this PR in staging.

@balajialg balajialg merged commit 9eac61b into berkeley-dsep-infra:staging Sep 21, 2023
2 checks passed
shaneknapp added a commit that referenced this pull request Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request python package PyMC for Data 102
3 participants