-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Isolate data102 hub to have its own image #5054
Isolate data102 hub to have its own image #5054
Conversation
you will also need to add entries in |
Thanks @shaneknapp! Just added the entry in CircleCI. Let me know if the config changes are correct. edit: I will look into the yaml issue today evening (once I get free) |
you should check to see if they would like the jupyterlab interface by default (which i would strongly recommend). if they do, then you'll need to add the following bits in the
https://github.com/berkeley-dsep-infra/datahub/blob/staging/deployments/data101/config/common.yaml#L167 |
@shaneknapp Data102's nbgitpuller links launches their assignments in the lab interface by default. In fact, the Data 102 hub currently launches the lab interface directly without the config changes shared above. Is it necessary to add this block given this context? Having said that, I added the required config changes in common.yml and commented out python-mode. Thanks for the recommendations! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor note about jupyterlab being included twice.
afaik, this is something required by jupyterlab 4... @ryanlovett, @felder and i had to do this for stat159, data100 and data101. |
Thanks @ryanlovett for catching the duplicate entry. Fixed it in the latest commit |
@shaneknapp Got it. Thanks for the clarification :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments about probably unneeded packages.
this looks good to merge whenever we get the word from the data102 folks! |
@shaneknapp @ryanlovett Merging this PR to staging as Data 102 folks gave a heads up! They would like to test this PR in staging. |
Resolves #5037 and #4953
The new image builds successfully on my local machine. Fingers crossed about CI/CD
Reference for this PR: #4423 , #4852, #5042
This PR needs to get merged once we get the confirmation from the course staff about upgrading to python 3.11 and list of packages installed.