Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install latest kubespawner on hub image #5060

Merged

Conversation

shaneknapp
Copy link
Contributor

trying out @yuvipanda 's suggestion from jupyterhub/zero-to-jupyterhub-k8s#3229 (comment)

hash generation:

(dh) ➜  kubespawner git:(main) git rev-parse origin/main
d60146f5fe9cd31e09acf13c377d9334ecf59c9b

@ryanlovett
Copy link
Collaborator

@shaneknapp Great that it has been fixed upstream! I think this change is probably sufficient.

The other approach would be to update the version in hub/requirements.yaml and images/hub/Dockerfile from 3.0.2 to, say, the version that was released today, https://hub.jupyter.org/helm-chart/#development-releases-jupyterhub. This might be necessary if kubespawner master needs other newer things that the chart brings in. But it might be worthwhile to test just the kubespawner update.

@shaneknapp
Copy link
Contributor Author

@shaneknapp Great that it has been fixed upstream! I think this change is probably sufficient.

The other approach would be to update the version in hub/requirements.yaml and images/hub/Dockerfile from 3.0.2 to, say, the version that was released today, https://hub.jupyter.org/helm-chart/#development-releases-jupyterhub. This might be necessary if kubespawner master needs other newer things that the chart brings in. But it might be worthwhile to test just the kubespawner update.

yeah, let's just try kubespawner first...

@shaneknapp
Copy link
Contributor Author

shaneknapp commented Sep 22, 2023

ok, so i don't feel comfortable pushing this out until we're in off-hours. this means i will either do that this weekend, or first thing monday morning. tbh, probably the latter.

edit: or perhaps first thing in the morning mid-week, so we can discuss a bit more on slack....

@shaneknapp
Copy link
Contributor Author

just tested on logodev-staging w/a couple of users and after a chartpress, the logs show a restart but no error messages regarding orphaned users.

i'll let the idle culler do it's thing and see if the pods end up orphaned.

@shaneknapp shaneknapp merged commit cdc3d97 into berkeley-dsep-infra:staging Sep 24, 2023
2 checks passed
@shaneknapp shaneknapp deleted the use-master-kubespawner branch September 28, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants