Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data101] Add trifacta pip package #5069

Closed
wants to merge 2 commits into from

Conversation

frank-lsf
Copy link
Contributor

@@ -77,6 +77,7 @@ dependencies:
- statsmodels==0.14.0
- sympy==1.10.1
- tornado==6.2.0
- trifacta==8.5.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @franklsf95 ! there's no conda package for this, only pypi. move the package req from the conda block down to the pip block at the end of the file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, fixed.

@shaneknapp
Copy link
Contributor

ugh... looks like they only support py3.7 and py3.8: https://pypi.org/project/trifacta/

Python Requirements
Python 3.7, Python 3.8
For version requirements of specific Python components, please see requirements.txt in this package.

@frank-lsf
Copy link
Contributor Author

ugh... looks like they only support py3.7 and py3.8: https://pypi.org/project/trifacta/

Python Requirements
Python 3.7, Python 3.8
For version requirements of specific Python components, please see requirements.txt in this package.

Alas. Is there a way to pass --ignore-requires-python to pip?

@shaneknapp
Copy link
Contributor

shaneknapp commented Sep 26, 2023 via email

@frank-lsf
Copy link
Contributor Author

i'm not sure that even if we could, that it would be recommended. personally, i'd test this out locally in a python env and see if it behaves properly. there have been a lot of changes from 3.8 to 3.11....

On Tue, Sep 26, 2023 at 12:42 PM Frank Luan @.> wrote: ugh... looks like they only support py3.7 and py3.8: https://pypi.org/project/trifacta/ Python Requirements Python 3.7, Python 3.8 For version requirements of specific Python components, please see requirements.txt in this package. Alas. Is there a way to pass --ignore-requires-python to pip? — Reply to this email directly, view it on GitHub <#5069 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMIHLGVCCNJUXFG3KM2B73X4MVZDANCNFSM6AAAAAA5IA5WYI . You are receiving this because you commented.Message ID: @.>

I did test locally and it can install on Python 3.11. But let us do more tests locally and get back to you..

@shaneknapp
Copy link
Contributor

closing this as it's been untouched and probably not relevant anymore. @franklsf95 you can re-open this if you feel we need to.

@shaneknapp shaneknapp closed this Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants