Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DH-123] remove the pinned version of kubespawner #5083

Merged

Conversation

shaneknapp
Copy link
Contributor

v6.1 was released today, which contains the fix for the orphaned resources and disconnection from a hub's underlying filesystem.

https://pypi.org/project/jupyterhub-kubespawner/
https://jupyterhub-kubespawner.readthedocs.io/en/6.1.0/changelog.html#id2

Copy link
Collaborator

@ryanlovett ryanlovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe removing the line will cause things to break again, and keeping main will work for a while, but tracking the latest git will eventually hurt us.

images/hub/Dockerfile Show resolved Hide resolved
@ryanlovett
Copy link
Collaborator

Looks good!

@shaneknapp
Copy link
Contributor Author

alright, i'll chartpress locally and test on logodev before merging

@shaneknapp
Copy link
Contributor Author

shaneknapp commented Sep 28, 2023

testing seemed to show that everything worked!

@shaneknapp shaneknapp merged commit 0472629 into berkeley-dsep-infra:staging Sep 28, 2023
2 checks passed
@shaneknapp shaneknapp deleted the revert-kubespawner-patch branch September 28, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants