add argument for inactive_since to specify other timedeltas #5104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, I get:
Traceback (most recent call last):
File "/tmp/datahub/scripts/./delete-unused-users.py", line 116, in <module>
argparser.add_argument(
File "/usr/lib/python3.11/argparse.py", line 1480, in add_argument
return self._add_action(action)
^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/argparse.py", line 1862, in _add_action
self._optionals._add_action(action)
File "/usr/lib/python3.11/argparse.py", line 1682, in _add_action
action = super(_ArgumentGroup, self)._add_action(action)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/argparse.py", line 1494, in _add_action
self._check_conflict(action)
File "/usr/lib/python3.11/argparse.py", line 1631, in _check_conflict
conflict_handler(action, confl_optionals)
File "/usr/lib/python3.11/argparse.py", line 1640, in _handle_conflict_error
raise ArgumentError(action, message % conflict_string)
argparse.ArgumentError: argument -h/--hub_url: conflicting option string: -h
|
thanks for the PR! i tested this locally and it behaves as expected. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #5076 (comment), #5095 and #5093
I added an argument to configure the inactivity period after which users should be considered for deletion.
(The advanced timedelta argument parsing was more of a fun exercise than really necessary 😉)
(Also, I'd like to politely ask you to add the hacktoberfest-accepted label to this PR if possible)