Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DH-66] duplicate install of jupyter-rsession-proxy might be breaking things #5187

Conversation

shaneknapp
Copy link
Contributor

@shaneknapp shaneknapp commented Nov 2, 2023

jupyter-rsession-proxy is installed both via the dockerfile and environment.yml, only needs to happen once. let's try environment.yml first!

@shaneknapp shaneknapp changed the title [DH-66] duplicate install might be breaking things [DH-66] duplicate install of jupyter-rsession-proxy might be breaking things Nov 2, 2023
@ryanlovett
Copy link
Collaborator

@shaneknapp Yes, no need for python packages to be installed via Dockerfile, especially if they're on pypi or conda-forge.

@shaneknapp shaneknapp merged commit 42b38d2 into berkeley-dsep-infra:staging Nov 2, 2023
2 checks passed
@shaneknapp shaneknapp deleted the unbork-publichealth-part-deux branch November 2, 2023 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants