Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nbclassic and notebook7 to data8 image #5341

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Add nbclassic and notebook7 to data8 image #5341

merged 2 commits into from
Jan 3, 2024

Conversation

balajialg
Copy link
Contributor

@balajialg balajialg commented Jan 3, 2024

Troubleshooting why I am not able to launch nb7 in data8 image

@shaneknapp created this PR directly as #5340 was successful

Copy link
Collaborator

@ryanlovett ryanlovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion regarding notebook.

@@ -21,6 +22,7 @@ dependencies:

# Items not in conda forge
- pip:
- notebook==7.0.6
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@balajialg notebook should be put into the conda package section rather than under pip in my opinion. Version 7.0.6 is available in conda-forge, https://anaconda.org/conda-forge/notebook

@balajialg balajialg changed the title Add nbclassic to data8 image and move notebook7 installation under pip block (mimicing a11y hub image) Add nbclassic and notebook7 to data8 image Jan 3, 2024
@balajialg
Copy link
Contributor Author

balajialg commented Jan 3, 2024

@ryanlovett Thanks for your feedback! I just made a new commit that adds notebook 7 under the conda package section

@shaneknapp shaneknapp merged commit f16047b into berkeley-dsep-infra:staging Jan 3, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants