Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh Data 8 image and test whether it launches notebook 7 and lab 4 #5349

Merged
merged 4 commits into from
Jan 9, 2024
Merged

Refresh Data 8 image and test whether it launches notebook 7 and lab 4 #5349

merged 4 commits into from
Jan 9, 2024

Conversation

balajialg
Copy link
Contributor

@balajialg balajialg commented Jan 8, 2024 •
edited
Loading

List of tasks done as part of this PR,

  • Removed Dockerfile so that Data 8 follows repo2docker structure
  • Added entries in the hubploy.yaml
  • Commented out infra-reqs which provides old version of lab and notebook
  • Added necessary packages from infra-reqs to env.yml file
  • Removed packages under pip and moved them under conda block (if they had an entry in anaconda.org)

Thanks @ryanlovett for the suggestions!

@balajialg balajialg requested a review from felder January 8, 2024 23:44
shaneknapp
shaneknapp approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@shaneknapp shaneknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

ryanlovett
ryanlovett approved these changes Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@ryanlovett ryanlovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@balajialg balajialg merged commit d52f06b into berkeley-dsep-infra:staging Jan 9, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanlovett ryanlovett ryanlovett approved these changes

@shaneknapp shaneknapp shaneknapp approved these changes

@felder felder Awaiting requested review from felder

Assignees
No one assigned
Labels
configuration dockerfile hub: data8 singleuser-image
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@balajialg @shaneknapp @ryanlovett