-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add retrolab package to the Data8 image #5351
Conversation
actually, do you need retrolab? from their github repo:
|
@shaneknapp Good point! RetroLab is incompatible with Lab 4.0 and the build failed for that particular reason.
However, we need retro because I tried launching a new retro notebook in the Data 8 Staging hub which has the latest NB7 and Lab 4 and it returned a 404 error. Specifying retro in nbgitpuller prepends "retro/tree" to the URL |
i'm not surprised that this is what's happening! if retrolab isn't installed, then any links created via nbgitpuller that specify it will fail w/a 404. basically, if retrolab is a requirement, we can't run jupyterlab 4. is there a reason why we can't update the nbgitpuller links/docs/etc to reflect that retrolab is EOL? |
@shaneknapp Yes, we need to update the nbgitpuller docs to reflect that retro lab is EOL. Some upstream engagement is required to remove RetroLab from this list - https://nbgitpuller.readthedocs.io/en/latest/link.html Do you know if Notebook 7 and Lab 3 are compatible? Data 8 hub requires Nb 7 but doesn't need Lab 4. If we downgrade to Lab 3, we can support retro at least till spring break. Instructors need to regenerate the links for the course website and point them to the nb7 interface. Retro could act as a backup interface till the transition is done. |
after confirming my suspicions locally w/repo2docker: i don't think notebook 7 and jupyterlab < 4 will work together. |
The instructors will need to update their nbgitpuller links anyways for the new materials-sp24 repo, so switching the links from retro to notebook at the same time makes sense. I wonder if we can add a redirect on the user server from /retro/tree (retro) to /tree (nb7). Few would notice since NB7 is the new retro. This can be done with a jupyter-server-proxy config, but it may be possible to do in a jupyter config or helm chart config. But it'd be much easier to ditch retro and communicate the change. |
@ryanlovett I agree that switching to nb7 is the way forward. We might still need to support retro for a few weeks in case nb7 throws any new surprises for instructors. We encountered issues like this when we transitioned from classic to retro - #2992. nb7 has never been deployed in a course setting, unlike jl4 which was tested in Data 100 during SU 23. A redirect for /retro/tree to /tree would be desirable but whether that is feasible given the tight timelines is a question I have. |
Closing this PR as we decided not to worry about retrolab for the Data 8 hub! |
(Backup) In case the Data 8 instructional team decides to use the retro lab during SP 24!