Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sp24 DS100] 1. Admin access (thru bcourses Admins user group) 2. Grant DS100 Content Team 4G RAM. #5375

Merged
merged 7 commits into from
Jan 16, 2024
Merged

[Sp24 DS100] 1. Admin access (thru bcourses Admins user group) 2. Grant DS100 Content Team 4G RAM. #5375

merged 7 commits into from
Jan 16, 2024

Conversation

CharlieJCJ
Copy link
Contributor

Start of semester datahub access request.

Thanks,
Charlie

@CharlieJCJ CharlieJCJ mentioned this pull request Jan 13, 2024
Closed
@balajialg
Copy link
Contributor

balajialg commented Jan 15, 2024 •
edited
Loading

@CharlieJCJ thanks for creating this PR! minor edit - Can you please link the github issue #5376 as a comment in the PR?

@CharlieJCJ
Copy link
Contributor Author

For sure! Issue linked.

@CharlieJCJ
Copy link
Contributor Author

CharlieJCJ commented Jan 15, 2024 •
edited
Loading

Yeah, just a note. I added a commit to revert back to prev fa23 package version and will open a separate PR, issue for package updates in sp24.

@CharlieJCJ
Copy link
Contributor Author

@balajialg waiting for merge approval, thanks!

@balajialg
Copy link
Contributor

balajialg commented Jan 16, 2024 •
edited
Loading

@CharlieJCJ Sounds good. Seems like I didn't communicate the change to the PR properly last time. Can you please link the github issue #5376 as a comment in the PR for our internal tracking purposes? (Example linked). Infra admins prefer that approach for all PRs making changes to config and images.

I will merge the PR to staging ASAP. Having said that, @shaneknapp intends to merge all the changes to prod after 5 PM today. So, these changes will only go live tonight. Hope that works for you and your team @CharlieJCJ

@CharlieJCJ
Copy link
Contributor Author

Fixed all. Thanks!

ryanlovett
ryanlovett approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@ryanlovett ryanlovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@balajialg Looks good to me.

@balajialg balajialg merged commit 7a06302 into berkeley-dsep-infra:staging Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaneknapp shaneknapp shaneknapp requested changes

@ryanlovett ryanlovett ryanlovett approved these changes

Assignees
No one assigned
Labels
configuration hub: data100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CharlieJCJ @balajialg @shaneknapp @ryanlovett