Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] downgrade nbgitpuller and jupyterhub in dev-r hub image #5693

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Conversation

balajialg
Copy link
Contributor

@shaneknapp Let me know if you are okay with making changes to infra-req for dev-r? I will test this in staging and then revert the changes. Yet another data point that we can use to report upstream.

Copy link
Contributor

@shaneknapp shaneknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this won't work as expected due to the hub image itself having a higher version of jupyterhub installed. you'll need to build and push a new image w/the lower deps installed.

i believe that you can specify this in staging.yml as hub.image.<etc>. @ryanlovett have you done this before?

@shaneknapp
Copy link
Contributor

i'd also considering experimenting by also lowering the jupyterhub version to 4.0.x and keeping nbgitpuller at 1.2.1

@balajialg
Copy link
Contributor Author

balajialg commented Apr 24, 2024

@shaneknapp Got it, thanks. If you can redirect me to a documentation then I will take a look at it. Or else we can probably do this during a short check-in if you are available.

@ryanlovett
Copy link
Collaborator

@shaneknapp I haven't done this exact thing before, but it should be possible to set a value in a deployment that masks any corresponding value in hub/values.yml. This would indeed be hub.image. To build a new hub image you'd modify images/hub/Dockerfile and build a new hub image with chartpress.

chartpress builds and pushes a new image, but it also changes the hub version in the top-level config automatically. So either you would let it do that, test a hub with hubploy, and not commit those changes until you want to deploy them for all hubs; or you would remove the top-level config changes to hub.image and manually insert them into the testing hub config, and commit that.

@shaneknapp
Copy link
Contributor

@shaneknapp I haven't done this exact thing before, but it should be possible to set a value in a deployment that masks any corresponding value in hub/values.yml. This would indeed be hub.image. To build a new hub image you'd modify images/hub/Dockerfile and build a new hub image with chartpress.

chartpress builds and pushes a new image, but it also changes the hub version in the top-level config automatically. So either you would let it do that, test a hub with hubploy, and not commit those changes until you want to deploy them for all hubs; or you would remove the top-level config changes to hub.image and manually insert them into the testing hub config, and commit that.

ah i see. i created a PR to do that... could you take a look and we can carry that convo on over there? #5696

@shaneknapp
Copy link
Contributor

@shaneknapp I haven't done this exact thing before, but it should be possible to set a value in a deployment that masks any corresponding value in hub/values.yml. This would indeed be hub.image. To build a new hub image you'd modify images/hub/Dockerfile and build a new hub image with chartpress.
chartpress builds and pushes a new image, but it also changes the hub version in the top-level config automatically. So either you would let it do that, test a hub with hubploy, and not commit those changes until you want to deploy them for all hubs; or you would remove the top-level config changes to hub.image and manually insert them into the testing hub config, and commit that.

ah i see. i created a PR to do that... could you take a look and we can carry that convo on over there? #5696

figured it out! #5696 (comment)

@shaneknapp
Copy link
Contributor

i would suggest that after merging this and testing, to open another PR to bump nbgitpuller to 1.2.1 .

@balajialg
Copy link
Contributor Author

@shaneknapp Sounds good. Will do

@balajialg balajialg merged commit e0dc5dd into berkeley-dsep-infra:staging Apr 24, 2024
21 checks passed
@balajialg balajialg deleted the dev_r branch April 25, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants