-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test] downgrade nbgitpuller and jupyterhub in dev-r hub image #5693
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this won't work as expected due to the hub image itself having a higher version of jupyterhub installed. you'll need to build and push a new image w/the lower deps installed.
i believe that you can specify this in staging.yml
as hub.image.<etc>
. @ryanlovett have you done this before?
i'd also considering experimenting by also lowering the jupyterhub version to 4.0.x and keeping nbgitpuller at 1.2.1 |
@shaneknapp Got it, thanks. If you can redirect me to a documentation then I will take a look at it. Or else we can probably do this during a short check-in if you are available. |
@shaneknapp I haven't done this exact thing before, but it should be possible to set a value in a deployment that masks any corresponding value in hub/values.yml. This would indeed be hub.image. To build a new hub image you'd modify images/hub/Dockerfile and build a new hub image with chartpress. chartpress builds and pushes a new image, but it also changes the hub version in the top-level config automatically. So either you would let it do that, test a hub with hubploy, and not commit those changes until you want to deploy them for all hubs; or you would remove the top-level config changes to hub.image and manually insert them into the testing hub config, and commit that. |
ah i see. i created a PR to do that... could you take a look and we can carry that convo on over there? #5696 |
figured it out! #5696 (comment) |
i would suggest that after merging this and testing, to open another PR to bump nbgitpuller to |
@shaneknapp Sounds good. Will do |
@shaneknapp Let me know if you are okay with making changes to infra-req for dev-r? I will test this in staging and then revert the changes. Yet another data point that we can use to report upstream.