Prevent students from accessing shared data. #5695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All users can currently read the _shared path, so use a different directory. I've created it on the filestore. Also collapse the course::1524699 group into the existing one, and remove the custom.admin entry. The latter is only needed for pure admins, and we're moving away from that model.
|
Thanks @ryanlovett for fixing the config! If we figure out ways to start reading entries from BigQuery then we can even do away with storing the logs in shared folder |
|
Yeah, totally agree @balajialg. BigQuery would be much faster. |
ryanlovett
added a commit
that referenced
this pull request
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All users can currently read the _shared path, so use a different directory. I've created it on the filestore. Also collapse the course::1524699 group into the existing one, and remove the custom.admin entry. The latter is only needed for pure admins, and we're moving away from that model.
Lastly, the shared storage should be read-only for datahub admins too because we don't want to accidentally edit the log files. If output is generated from this data, it can be saved to datahub admins' home dirs. Admins can upload new data to the filestore without having to go through the hub, so I don't think this will be a problem. An alternative would be to have the path be read-write, but set the modes on the logs to be 444.