Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DH-276] update cluster switchover doc #5750

Merged

Conversation

shaneknapp
Copy link
Contributor

@shaneknapp shaneknapp commented May 21, 2024

update our cluster switchover docs to something relevant, recent and (mostly) complete.

at some point, i'd love for this doc to be used as a template for a "how to deploy our infra from zero to datahub".

@github-actions github-actions bot added the documentation Issues around adding and modifying docs label May 21, 2024
@shaneknapp
Copy link
Contributor Author

@ryanlovett @felder it'd be great if you could put your peepers on these changes for any feedback.

thanks!

@ryanlovett
Copy link
Collaborator

@shaneknapp Seems clear to me! I didn't participate in most the upgrade so I don't know if anything is missing. The cert-manager section seems accurate though, from what I recall.

Either in this PR or another, it might be good to document in a sentence or two why it can be necessary to deploy a new cluster.

@shaneknapp shaneknapp requested a review from felder June 13, 2024 22:53
felder
felder previously requested changes Jun 14, 2024
Copy link
Contributor

@felder felder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented and suggested edits for the specific section you asked me about. I think everything else looks reasonable, but it's hard to know for sure. I guess we can cross that bridge the next time we do a cluster rotation and refer to this doc.

docs/admins/howto/clusterswitch.md Outdated Show resolved Hide resolved
@shaneknapp
Copy link
Contributor Author

@felder let me know if the changes from 79bcd14f1f76242984e362c92bffabb9ebb66261 look good!

@shaneknapp
Copy link
Contributor Author

shaneknapp commented Jun 17, 2024

@shaneknapp Seems clear to me! I didn't participate in most the upgrade so I don't know if anything is missing. The cert-manager section seems accurate though, from what I recall.

Either in this PR or another, it might be good to document in a sentence or two why it can be necessary to deploy a new cluster.

0558bb9
and
a788ff3

@shaneknapp shaneknapp merged commit a297d4a into berkeley-dsep-infra:staging Jun 17, 2024
21 checks passed
@shaneknapp shaneknapp deleted the cluster-switch-details branch June 17, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues around adding and modifying docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants