Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DH-317] Install quarto in Dev hub (dashboard image) #5829

Merged
merged 3 commits into from
Jul 2, 2024
Merged

[DH-317] Install quarto in Dev hub (dashboard image) #5829

merged 3 commits into from
Jul 2, 2024

Conversation

balajialg
Copy link
Contributor

So that Sophie can explore quarto dashboards in Dev hub

@ryanlovett
Copy link
Collaborator

ryanlovett commented Jul 2, 2024

I recommend not using R code to script the installation of quarto. I also think this method will fail because I believe the user running install.R in repo2docker doesn't have root privileges. I believed this passed CI because it is the secondary image and hubploy doesn't build secondary images.

repo2docker doesn't make quarto installation easy because quarto is not in Ubuntu jammy repos nor is it in conda-forge.
Upstream's example at https://github.com/cwickham/binder-example/ installs into ~/.local/bin, but ~ gets displaced by users' hub storage.

So either we have to use a Dockerfile, like what stat20 uses, or we have to find a way to seed content for repo2docker's appendix. That can run commands as root.

Lastly, it'd probably worth creating an issue to request that quarto be installed (along with RStudio, shiny, etc.) in repo2docker's R build packs.

@ryanlovett
Copy link
Collaborator

Actually, there is a quarto package in conda, https://anaconda.org/conda-forge/quarto. So it should just go into the environment.yml.

@balajialg
Copy link
Contributor Author

Thanks @ryanlovett for the suggestion. I just made a commit which added the quarto package to the environment.yml file. That seems to be a simple process to enable quarto. Good to know!

@@ -1,5 +1,6 @@
#!/usr/bin/env r
#!/usr/bin/env R
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering about this since it is technically correct, but hasn't been a problem. This script is evidently passed to R rather than made executable and run directly. The upstream example doesn't even have a hashbang.

@balajialg
Copy link
Contributor Author

balajialg commented Jul 2, 2024

@ryanlovett I will merge the PR for now. Will fix it if there are issues.

@balajialg balajialg merged commit 2a5a9a5 into berkeley-dsep-infra:staging Jul 2, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants