UGR GKE as GCP Deployments; minor docs edit #5844
Conversation
github-actions
bot
added
documentation
|
also, could you run |
Seems to be running clean! Thanks! |
actually, you should run it this way: |
...so we are going looser than the .yamllint.yaml file? Should we remove the .yamllint.yaml from the project? Note this: Seems you either do -d relaxed or you do -c .yamllint.yaml if you want newline & trailing spaces rules...but yeah it seems that -d, by definition, ignores the .yamllint.yaml file. Is that so? |
|
hmm, i cribbed the file + instructions from 2i2c... i didn't look too
closely at it initially but i think you might be right!
…On Mon, Jul 8, 2024 at 11:53 AM Greg Merrit ***@***.***> wrote:
also, could you run yamllint on your newly created yamls?
Seems to be running clean! Thanks!
(base) MacBook-Pro-2020:configs gregm$ yamllint -c ../../../../../.yamllint.yaml gke_ugresearch.yaml
(base) MacBook-Pro-2020:configs gregm$ yamllint -c ../../../../../.yamllint.yaml node_pool_ugr01.yaml
(base) MacBook-Pro-2020:configs gregm$
actually, you should run it this way: yamllint -d relaxed
vendor/google/ugr/gke
...so we are going looser than the .yamllint.yaml file? Should we remove
the .yamllint.yaml from the project? Note this:
$ more ../../../../../.yamllint.yaml
# This config represents running the command `yamllint -d relaxed .` with the
# following extra rules:
#
# new-line-at-end-of-file:
# level: warning
# trailing-spaces:
# level: warning
#
Seems you either do *-d relaxed* or you do *-c .yamllint.yaml* if you
want newline & trailing spaces rules...but yeah it seems that -d, by
definition, ignores the .yamllint.yaml file. Is that so?
—
Reply to this email directly, view it on GitHub
<#5844 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMIHLGFODVJLWFY7S4GBVLZLLN2LAVCNFSM6AAAAABKPWMK5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJUHE2DCNBYHA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
:P Ok. Well, running clean in both modes! |
|
i'd also recommend putting a |
Ok, added a README.md! |
deployments/ugr01/hubploy.yaml
Outdated
| @@ -0,0 +1,17 @@ | |||
| images: | |||
| images: | |||
| - name: us-central1-docker.pkg.dev/ucb-datahub-2018/user-images/primary-user-image | |||
There was a problem hiding this comment.
i think it will serve us better if we have a separate image for this hub. i'd consider cribbing the image config from data100 and using that instead.
|
btw -- the ugr cluster is currently undeployed (er, I had it up & down a number of times briefly to test out the scripts, but it is currently gone). I do believe I should deploy it before we move this pr to staging, else datahub may "expect" the named resources to be there, but will not find them! Oh and -- there are currently tiny VM sizes for core & user pools in the config. |
|
So yeah I'm not feeling super-great about the custom image...on the one hand, it really is basically a data100 clone, BUT I can't even repo2docker data100 proper (and ditto for multiple other images) without error, either on my Mac or on a GCP linux VM where I've repo2docker'd datahub images successfully in the past...so I don't trust it etc. :/ More time fussing w/ repo2docker than actually making this change, so I'm tossing the custom image edits into this PR as a talking point. |
|
word, let me try building this image locally and see what happens...
…On Tue, Jul 30, 2024 at 1:10 PM Greg Merrit ***@***.***> wrote:
So yeah I'm not feeling super-great about the custom image...on the one
hand, it really is basically a data100 clone, BUT I can't even repo2docker
data100 proper (and ditto for multiple other images) without error, either
on my Mac or on a GCP linux VM where I've repo2docker'd datahub images
successfully in the past...so I don't trust it etc. :/
More time fussing w/ repo2docker than actually making this change, so I'm
tossing the custom image edits into this PR as a talking point.
—
Reply to this email directly, view it on GitHub
<#5844 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMIHLG7HROZAV7VQMHRWDTZO7XMFAVCNFSM6AAAAABKPWMK5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJZGEZDMNBXGQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
I'm going merge...tomorrow...so it's more chill. |
|
|
I believe that my answer is here, but I'm not sure how to connect the dots... |
Deploy with the .sh scripts. Resource size/number can be changed as needed. Additional node pools may be added by duplicating the node_pool_ugr01.yaml and naming/customizing, and doing likewise with a new .sh script (e.g., copy deploy_node_pool_ugr01.sh) that points to the new node pool's .yaml config.
Deployments are updatable by simply editing config .yaml and re-running corresponding .sh.