Clean up Dev hub's dashboard image and install mystmd,voila and voici packages #5851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balajialg
changed the title
balajialg
changed the title
ryanlovett
requested changes
Jul 11, 2024
|
@ryanlovett Thanks for the detailed feedback. I just created a PR addressing all your comments. The image built successfully in my local docker setup. |
|
I am merging the changes to staging inorder to test it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref:
https://anaconda.org/conda-forge/voila
https://anaconda.org/conda-forge/voila
https://anaconda.org/conda-forge/mystmd
Image was building for a long time locally (tried multiple iterations locally - it kept building. So, wanted to check whether it built via CI)Okay, debugging locallyCommented out unnecessary packages for the dashboard image and added above packages which are needed to build dashboard. When I tested this image locally, it built successfully.