Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DH-301] combine staging/prod deploy to one workflow, skip if we need to deploy all hubs #6018

Merged
merged 4 commits into from
Aug 26, 2024
Merged

[DH-301] combine staging/prod deploy to one workflow, skip if we need to deploy all hubs #6018

merged 4 commits into from
Aug 26, 2024

Conversation

shaneknapp
Copy link
Contributor

@shaneknapp shaneknapp commented Aug 26, 2024 •
edited
Loading

a few things in this PR:

  1. if we need to deploy all hubs due to the jupyterhub-deployment or hub-images PR labels being present, we should skip the deploy-hubs.yaml workflow altogether.
  2. i combined both prod and staging deploys for individual hubs in to deploy-hubs.yaml, and deleted deploy-to-prod and deploy-to-staging.
  3. some minor refactoring of deploy-jupyterhub-base-images.yaml
  4. renamed the labeling step to be apply-labels instead of triage
  5. all calls to hubploy are no-ops, but all workflows will run

@shaneknapp shaneknapp merged commit 522bb9e into berkeley-dsep-infra:staging Aug 26, 2024
22 checks passed
@shaneknapp shaneknapp deleted the more-workflow-tweaking branch August 26, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felder felder Awaiting requested review from felder

@balajialg balajialg Awaiting requested review from balajialg

@ryanlovett ryanlovett Awaiting requested review from ryanlovett

Assignees
No one assigned
Labels
build-infra hub: a11y jupyterhub-deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shaneknapp