[DH-301] hopefully fixing bash arrays + parsing #6030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i manually added two hub labels for no-op testing when i merge to staging. |
|
ok that seemed to work!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after checking out the results/execution logs of one of the new github workflows (https://github.com/berkeley-dsep-infra/datahub/actions/runs/10584196501/job/29327903196) i noticed that the hub names to deploy weren't properly being added to the array i defined called
HUBS:this is odd, and i even tested locally and it should have properly populated the list:
so... i think the extra space in this expression will force things to work: `HUB+="$hub "
however, this is a sign that i think we should NOT use bash for stuff like this and instead have some small python helper scripts that will at least behave in an expected way.