Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removing extra CNAME #6329

Merged
merged 1 commit into from
Oct 2, 2024
Merged

removing extra CNAME #6329

merged 1 commit into from
Oct 2, 2024

Conversation

shaneknapp
Copy link
Contributor

No description provided.

@shaneknapp shaneknapp requested a review from ryanlovett October 2, 2024 23:10
ryanlovett
ryanlovett approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@ryanlovett ryanlovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the top-level file is not needed. GitHub Pages publication definitely did not work with the top-level file and without docs/CNAME.

@ryanlovett ryanlovett merged commit 34e859c into berkeley-dsep-infra:staging Oct 2, 2024
3 checks passed
@shaneknapp shaneknapp deleted the remove-leftover-cname branch October 14, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanlovett ryanlovett ryanlovett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shaneknapp @ryanlovett