Skip to content

Commit

Permalink
Move gtrieScanner from postBuild to appendix.
Browse files Browse the repository at this point in the history
This writes out a binary to /usr/local/bin/. I think this is better than putting it in a conda path since it isn't a conda executable. The appendix is necessary since it can run as root.
  • Loading branch information
ryanlovett committed Sep 24, 2024
1 parent 400e4fa commit ddf4dbc
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 13 deletions.
11 changes: 10 additions & 1 deletion Dockerfile.appendix
Original file line number Diff line number Diff line change
@@ -1,2 +1,11 @@
USER root
RUN ls -ld /usr/local/bin/

# As requested in slack.
# http://www.dcc.fc.up.pt/gtries/
# https://github.com/ComplexNetworks-DCC-FCUP/gtrieScanner
RUN wget -O /tmp/gtrieScanner.zip https://www.dcc.fc.up.pt/gtries/gtrieScanner_src_01.zip && \
unzip -d /tmp /tmp/gtrieScanner.zip && \
make -C /tmp/gtrieScanner_src_01 && \
install -o root -g root -m 0755 /tmp/gtrieScanner_src_01/gtrieScanner /usr/local/bin/

USER $NB_USER
12 changes: 0 additions & 12 deletions postBuild
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,3 @@ set -e
# installing chromium browser to enable webpdf conversion using nbconvert
export PLAYWRIGHT_BROWSERS_PATH=${CONDA_DIR}
playwright install chromium

# As requested in slack.
# http://www.dcc.fc.up.pt/gtries/
# https://github.com/ComplexNetworks-DCC-FCUP/gtrieScanner
cd /tmp
wget https://www.dcc.fc.up.pt/gtries/gtrieScanner_src_01.zip
unzip gtrieScanner_src_01.zip
cd gtrieScanner_src_01
make
# CONDA_DIR is writable by our UID in postBuild. Ideally this would be
# in /usr/local/bin/.
install -m 0755 gtrieScanner ${CONDA_DIR}/bin/

0 comments on commit ddf4dbc

Please sign in to comment.