Add repo2docker-action appendix. #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I chose the filename `Dockerfile.appendix` to reinforce the fact that the file should contain Dockerfile commands. There is also a convention for people to use filenames of the form `Dockerfile.dev`, `Dockerfile.prod`, etc.
The action did not properly include the file, so let's try specifying the full path.
This writes out a binary to /usr/local/bin/. I think this is better than putting it in a conda path since it isn't a conda executable. The appendix is necessary since it can run as root.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I chose the filename
Dockerfile.appendixto reinforce the fact that the file should contain Dockerfile commands. There is also a convention for people to use filenames of the formDockerfile.dev,Dockerfile.prod, etc.