Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expanded nook UI and Reservation booking form changes #237

Open
wants to merge 33 commits into
base: dev
Choose a base branch
from
Open

Expanded nook UI and Reservation booking form changes #237

wants to merge 33 commits into from

Conversation

arkokoley
Copy link
Collaborator

Dependent on PR #226.

Contains the UI improvement as mentioned in issue #219

Also, Contains improvements and fixes as detailed in Aug 21 Milestone

arkokoley added 30 commits June 11, 2017 00:52
@arkokoley
Prevent request and search for reservations that overlap with others.
07d2409 
Completes #65
@arkokoley
Test case for overlapping reservations
dd24c1d 
Also updates Factory for reservation to ensure non overlapping
reservations are created
@arkokoley
Collapsible sidebar.
02fbdda 
Part of UI overhaul, issue #217
@arkokoley
multi-search selection for locations
649553d 
Completes issue #218
@arkokoley
Time selection changed to dropdowns
74247aa 
Time selection is now optional
Completes issue #211
@arkokoley
Limiting a user to selecting hour/half hour
1551ffe 
Improved UI for selecting Any
Ref issue #211

Also auto reloads search results as locations change

Ref issue #218
@arkokoley
Retain nooks as sidebar is toggled
d478b07 
Ref Issue #217 comment
#217 (comment)
@arkokoley
Filter by amenities from response nooks
1ccf99e 
Ref issue #212
@arkokoley
Search for nooks by specifying capacity
68e555d 
Completes issue #123
@arkokoley
Removed matching rooms from sidebar filter
38292af
@arkokoley
Add Room type filter to sidebar
11245b4 
Issue #217
@arkokoley
Merge branch 'dev' into ui-improvements
ac0e3ab
@arkokoley
Completes nook search by capacity
a8b1012 
Fixes issue mentioned in
#123 (comment)
@arkokoley
Fixes bug #221
18ff1fb
@arkokoley
Fix for error in #221 arising from commit
c3ca2df 
18ff1fb

Fixes #224
@arkokoley
Fix nook registrations form fail on searching with "Any" time
5f099cb 
Fix issue #221
@arkokoley
Redirect to same search filter results after redirection
36ff94c 
Also renames search filters with better suited ids

Completes issue #175
@arkokoley
Removed old code related to removed filter fields
3eb31fd
@arkokoley
Fix nook helper code that fails in tests
89ebc76
@arkokoley
Basic expanded ui created
0976f73 
Ref issue #219
@arkokoley
WIP: Updated full-view column for nook registration
d27325b 
Ref issue #219
@arkokoley
WIP: Modify full column nook view
d10e3ba 
Added Reserve button which shows up when a nook a selected

Ref issue #219
@arkokoley
limit nook results to 4 in full column view
a7cf112 
Ref Issue #232
@arkokoley
Form autofill condition for no time selected
d0093e1 
Fix Issue #227
@arkokoley
Fixed booked reservations not showing up in full column view
68e756b 
Fixes issue #228
@arkokoley
Add styling to indicate selected nook
e0bf268 
Complete Issue #229
@arkokoley
Remove extraneous reservation form field
050aa98 
Ref Issue #233
@arkokoley
Add Day to reservation form.
d6a73bc 
Completes issue #236
@arkokoley
Reservation form cleanup
03158ff 
Complete issue #235
@arkokoley
Add No_of_people field to reservation form
9484684 
Also autopopulate no_of_people from search params

Completes Issue #234
@arkokoley arkokoley added this to the Aug 21 milestone Aug 28, 2017
@arkokoley
Copy link
Collaborator Author

@jdcc is this good to be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdcc jdcc Awaiting requested review from jdcc

@jessyurko jessyurko Awaiting requested review from jessyurko

@shubhpatel108 shubhpatel108 Awaiting requested review from shubhpatel108

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Aug 21
Development

Successfully merging this pull request may close these issues.
1 participant
@arkokoley