Skip to content

Commit

Permalink
refactor: make sure all flows send dd
Browse files Browse the repository at this point in the history
  • Loading branch information
bernardobridge committed Jan 24, 2024
1 parent 6a28f1b commit ce3375d
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 8 deletions.
1 change: 1 addition & 0 deletions .github/workflows/deploy-prod.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,6 @@ jobs:
contents: read
secrets:
AWS_DEPLOYER_ROLE: ${{ secrets.AWS_DEPLOYER_ROLE }}
DD_API_KEY: ${{ secrets.DD_API_KEY }}
with:
ENVIRONMENT: prod
1 change: 1 addition & 0 deletions .github/workflows/deploy-staging.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,6 @@ jobs:
contents: read
secrets:
AWS_DEPLOYER_ROLE: ${{ secrets.AWS_DEPLOYER_ROLE }}
DD_API_KEY: ${{ secrets.DD_API_KEY }}
with:
ENVIRONMENT: staging
1 change: 1 addition & 0 deletions .github/workflows/pull_request.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ jobs:
contents: read
secrets:
AWS_DEPLOYER_ROLE: ${{ secrets.AWS_DEPLOYER_ROLE }}
DD_API_KEY: ${{ secrets.DD_API_KEY }}
with:
ENVIRONMENT: ${{ github.actor }}-${{ github.event.pull_request.number }}
SHOULD_SEED_DB: true
Expand Down
16 changes: 8 additions & 8 deletions .github/workflows/run-performance-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,6 @@ on:
required: true
options: ['staging', 'prod', 'custom']
type: choice
SERVICE_URL:
description: 'Override the service URL'
required: false
type: string
TEST_TYPE:
description: 'Type of test to run'
required: true
Expand All @@ -21,16 +17,16 @@ on:
description: 'Version of the application under test'
required: true
type: string
SERVICE_URL:
description: 'Override the service URL'
required: false
type: string
workflow_call:
inputs:
ENVIRONMENT:
description: 'Environment to run the tests against'
required: true
type: string
SERVICE_URL:
description: 'Override the service URL'
required: false
type: string
TEST_TYPE:
description: 'Type of test to run'
required: true
Expand All @@ -39,6 +35,10 @@ on:
description: 'Version of the application under test'
required: true
type: string
SERVICE_URL:
description: 'Override the service URL'
required: false
type: string
secrets:
DD_API_KEY:
description: 'Datadog API key'
Expand Down

0 comments on commit ce3375d

Please sign in to comment.