This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cucumber-rails authors removed
web_steps.rb
in version 1.1.0 (cucumber/cucumber-rails#174) because they believed it led to misuse of Cucumber. (See The training wheels came off for more background.)I propose doing the same for cucumber-sinatra.
I removed the related template files and updated the generator.
features/step_definitions
is the default directory for step definitions, so rather than omit that directory it makes sense to create an emptyfeatures/step_definitions
to help new Cukers get started. We could also create a dummy features file and corresponding step definition file, but that might require additional thought to do the right thing.It doesn't look like there is any automated testing to verify my changes, but I did successfully run
cucumber-sinatra
with the updated version. Let me know whether I can help with any other testing. I also did not bump the version, since I don't know how you'd want to handle that.