Skip to content
This repository has been archived by the owner on Nov 9, 2017. It is now read-only.

Remove web_steps.rb #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove web_steps.rb #6

wants to merge 1 commit into from

Conversation

andycox
Copy link

@andycox andycox commented Feb 5, 2014

The cucumber-rails authors removed web_steps.rb in version 1.1.0 (cucumber/cucumber-rails#174) because they believed it led to misuse of Cucumber. (See The training wheels came off for more background.)

I propose doing the same for cucumber-sinatra.

I removed the related template files and updated the generator. features/step_definitions is the default directory for step definitions, so rather than omit that directory it makes sense to create an empty features/step_definitions to help new Cukers get started. We could also create a dummy features file and corresponding step definition file, but that might require additional thought to do the right thing.

It doesn't look like there is any automated testing to verify my changes, but I did successfully run cucumber-sinatra with the updated version. Let me know whether I can help with any other testing. I also did not bump the version, since I don't know how you'd want to handle that.

@bernd
Copy link
Owner

bernd commented Feb 12, 2014

Thanks for the patch!

Are you actively using cucumber-sinatra and are interested in maintaining this? :)

@andycox
Copy link
Author

andycox commented Feb 12, 2014

I just came across cucumber-sinatra, and I wouldn't say I'm actively using it, but I'm willing to help. Are you looking for help with this issue only or with the entire project?

@bernd
Copy link
Owner

bernd commented Feb 13, 2014

Well, I don't use it anymore so I was wondering if you would like to maintain the cucumber-sinatra project.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants