Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce connection timeout for HTTP redir check from 300 sec to 10 sec #41

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

wandernauta
Copy link
Contributor

This improves behavior especially if we have lots of HTTP redir checks, none of which can be reached. Currently, we would wait for each of those for 5 minutes (perhaps in parallel) and keep raising workers.

The following configuration demonstrates the issue, assuming packets can be sent to 240.0.0.1 but nothing comes back:

httpredir{fromUrl="http://240.0.0.1",toUrl="http://example.com"}

The 10 second timeout is taken from the default in MiniCurl, but note that the meaning is slightly different: that 10-second timeout covers the entire request and response, where this only covers connection. Httplib then defaults to a 5-second timeout per read call; it doesn't seem to have an equivalent "whole-conversation" timeout.

This would improve behavior especially if we have lots of HTTP redir
checks, none of which can be connected.
@berthubert berthubert merged commit 701d411 into berthubert:main Apr 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants