Reduce connection timeout for HTTP redir check from 300 sec to 10 sec #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves behavior especially if we have lots of HTTP redir checks, none of which can be reached. Currently, we would wait for each of those for 5 minutes (perhaps in parallel) and keep raising workers.
The following configuration demonstrates the issue, assuming packets can be sent to 240.0.0.1 but nothing comes back:
The 10 second timeout is taken from the default in MiniCurl, but note that the meaning is slightly different: that 10-second timeout covers the entire request and response, where this only covers connection. Httplib then defaults to a 5-second timeout per read call; it doesn't seem to have an equivalent "whole-conversation" timeout.