Add more ICMP ping options #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berthubert
reviewed
Jul 8, 2024
nuclearcat
force-pushed
the
add-ping-options
branch
from
ccf4ba4 to
90038f3
Compare
berthubert
reviewed
Jul 9, 2024
berthubert
reviewed
Jul 9, 2024
netmon.cc
Outdated
| double timeo=1.0; | ||
| if(!waitForData(sock, &timeo)) { // timeout | ||
|
|
||
| if(!waitForData(sock, &d_timeout)) { |
There was a problem hiding this comment.
one day waitForTimeout might start decrementing that timeout value, so best to keep this as 'double timeo = d_timeout'
There was a problem hiding this comment.
Amended sources, adjusted as you suggested.
Add support for df (Don't fragment) option, size, timeout. Signed-off-by: Denys Fedoryshchenko <[email protected]>
nuclearcat
force-pushed
the
add-ping-options
branch
from
90038f3 to
87563fe
Compare
berthubert
approved these changes
Jul 11, 2024
|
Thank you! And sorry for being a bit difficult. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for df (Don't fragment) option, size, timeout.