Fix animation #32
Open
Fix animation #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge from upstream
2) Reset transform from dismiss() if this CustomizableActionSheet is being reused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Beryu,
I would like to propose a fix on animation.
The problem will become more obvious, if I increase the height of custom view, and make the animation time longer.
Here's the video before the proposed fix, and after the proposed fix.
The idea of the fix is, the delta Y animation should be the height of the bottom sheet, not the y-position of bottom sheet
Before
before.mov
After
after.mov
At the same time, I am also proposing adding
self.itemContainerView.transform = CGAffineTransform.identitybefore settingframe. This enables us to clear off the transform fromdismiss(), if we are re-using thisCustomizableActionSheetThank you very much.