Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix setting hostname and port #257

Merged
merged 2 commits into from
Jan 10, 2024
Merged

fix setting hostname and port #257

merged 2 commits into from
Jan 10, 2024

Conversation

tuxmea
Copy link
Member

@tuxmea tuxmea commented Jan 10, 2024

when using env vars in CMD, one must use sh -c to allow variable evaluation

@tuxmea
fix setting hostname and port
55b6a69 
when using env vars in CMD, one must use `sh -c` to allow variable
evaluation
@tuxmea tuxmea requested a review from a team as a code owner January 10, 2024 09:41
@tuxmea tuxmea added bug Something isn't working docker Pull requests that update Docker code labels Jan 10, 2024
@tuxmea
we must exclude the shellcheck SC2086
54a214f 
reason: if we set the quoptes, the quotes will be also used by the
container.
the port must not have quotes.
@tuxmea tuxmea merged commit 33e29bc into main Jan 10, 2024
9 checks passed
@tuxmea tuxmea deleted the fixes branch January 10, 2024 10:34
@tuxmea tuxmea mentioned this pull request Jan 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwaffen rwaffen rwaffen approved these changes

Assignees
No one assigned
Labels
bug Something isn't working docker Pull requests that update Docker code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tuxmea @rwaffen