feat: update rubocop and implement suggestions #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert Waffen <[email protected]>
|
okay, unit tests start failing, so i'm not supposed to do it like this 🤔 |
Ouch sorry, should have taken a closer look. I made the same mistake as rubocop 🤦♂️ The method |
|
okay, will add a comment to skip the cop for this line |
Signed-off-by: Robert Waffen <[email protected]>
oneiros
approved these changes
Sep 6, 2024
bastelfreak
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @oneiros ,
is this okay so to do? Rubocop says i should do so.
The change in the layer.rb.
cheers, Robert