-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporary remove FileWriter support when exporting video #516
Temporary remove FileWriter support when exporting video #516
Conversation
921d92b
to
ad125c6
Compare
SonarCloud Quality Gate failed.
|
i tested and it technically works, but very weird to ask for filename after processing, IMHO. |
@meoso true, I prefer to select the file first, and in this way use less memory. But the problem is outside our code and not depends of us. We can try to migrate to a different library, but I don't know if there are other options out there. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week. |
I presume y'all don't want to go backwards, but version e.g. var NWversion;
switch (os.platform()) {
case 'linux':
NWversion ='0.48.4';
break;
default:
NWversion ='0.50.2';
} |
It does not only fail under Linux. Windows has the same problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
AUTOMERGE: (FAIL)
|
@McGiverGim - I have lost track of whether this is needed still? |
Yes it is. I've a suggestion of code to test to see if it fixes the real problem, maybe this week I can get some time for it. |
This must be reverted. It was an alternate solution. If we merged the other this must be reverted. |
Workaround for #492
Since some update of our code (I suppose some new Node version or similar), the
FileWriter
constructor.name
does not contain theFileWriter
value anymore, now it containsEventTarget
. This produces the behaviour of the issue.I've opened an issue in the library to see if we can get a real fix for that: thenickdude/webm-writer-js#31 because it is a good idea to stream to disk directly and not to memory.
But until then, this PR removes the
FileWriter
support and uses the "on memory" stream of the video.