Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajoute une connexion via ProConnect #2054

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/actions/LoginAction.scala
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,11 @@ object LoginAction {
)

def signupSessionKeys: List[String] =
List(Keys.Session.signupId, Keys.Session.signupLoginExpiresAt)
List(
Keys.Session.signupId,
Keys.Session.signupLoginExpiresAt,
Keys.Session.signupProConnectSubject
)

}

Expand Down
483 changes: 482 additions & 1 deletion app/controllers/LoginController.scala

Large diffs are not rendered by default.

21 changes: 19 additions & 2 deletions app/controllers/SignupController.scala
Original file line number Diff line number Diff line change
Expand Up @@ -139,10 +139,11 @@ case class SignupController @Inject() (
LoginAction.readUserRights(user).flatMap { userRights =>
(
for {
loginType <- maybeLinkUserToProConnectClaims(user.id, request)
userSession <- userService
.createNewUserSession(
user.id,
UserSession.LoginType.MagicLink,
loginType,
loginExpiresAt,
request.remoteAddress,
request.headers.get(USER_AGENT),
Expand Down Expand Up @@ -328,6 +329,18 @@ case class SignupController @Inject() (
)
)

private def maybeLinkUserToProConnectClaims(
userId: UUID,
request: Request[_]
): EitherT[IO, Error, UserSession.LoginType] =
request.session.get(Keys.Session.signupProConnectSubject) match {
case None => EitherT.rightT[IO, Error](UserSession.LoginType.MagicLink)
case Some(subject) =>
EitherT(
userService.linkUserToProConnectClaims(userId, subject)
).map(_ => UserSession.LoginType.ProConnect)
}

/** Note: parameter is curried to easily mark `Request` as implicit. */
private def withSignupInSession(
action: Request[_] => (SignupRequest, Instant) => Future[Result]
Expand Down Expand Up @@ -395,10 +408,14 @@ case class SignupController @Inject() (
// (this case happen if the signup session has not been purged after user creation)
(
for {
loginType <- maybeLinkUserToProConnectClaims(
existingUser.id,
request
)
userSession <- userService
.createNewUserSession(
existingUser.id,
UserSession.LoginType.MagicLink,
loginType,
loginExpiresAt,
request.remoteAddress,
request.headers.get(USER_AGENT),
Expand Down
12 changes: 11 additions & 1 deletion app/models/EventType.scala
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,6 @@ object EventType {
object ReopenUnauthorized extends Warn
object TerminateUnauthorized extends Warn
object ToCGURedirected extends Info
object UserAccessDisabled extends Info
object UserCreated extends Info
object UserDeleted extends Info
object UserEdited extends Info
Expand Down Expand Up @@ -194,6 +193,7 @@ object EventType {
object AuthWithDifferentIp extends Warn
object LoginByKey extends Info
object AuthBySignupToken extends Info
object UserAccessDisabled extends Info
object LoggedInUserAccountDeleted extends Warn
object UserSessionError extends Error
object PasswordPageShowed extends Info
Expand Down Expand Up @@ -228,6 +228,16 @@ object EventType {
object FSMatriculeError extends Error
object FSMatriculeChanged extends Info

// ProConnect
object ProConnectSecurityWarning extends Warn
object ProConnectError extends Error
object ProConnectUpdateProviderConfiguration extends Info
object ProConnectUserLoginSuccessful extends Info
object ProConnectSignupLoginSuccessful extends Info
object ProConnectLoginDeactivatedUser extends Error
object ProConnectUnknownEmail extends Warn
object ProConnectClaimsSaveError extends Error

val unauthenticatedEvents: List[EventType] = List(
GenerateToken,
ExpiredToken,
Expand Down
29 changes: 29 additions & 0 deletions app/models/ProConnectClaims.scala
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
package models

import java.time.Instant
import java.util.UUID

/** https://github.com/numerique-gouv/proconnect-documentation/blob/main/doc_fs/donnees_fournies.md#le-champ-sub
*
* ProConnect transmet systématiquement au Fournisseur de Services un identifiant unique pour
* chaque agent (le sub) : cet identifiant est spécifique à chaque Fournisseur d'Identité. Il est
* recommandé de l'utiliser pour effectuer la réconciliation d'identité.
*
* Le code est basé sur l'ancienne documentation :
*
* AgentConnect transmet systématiquement au Fournisseur de Services un identifiant unique pour
* chaque agent (le sub) : cet identifiant est spécifique à chaque couple Fournisseur de Services /
* Fournisseur d'Identité. Il ne peut donc pas être utilisé pour faire de la réconciliation
* d'identité : nous vous recommandons l'utilisation de l'email professionnel pour cet usage.
*/
case class ProConnectClaims(
subject: String,
email: String,
givenName: Option[String],
usualName: Option[String],
uid: Option[String],
siret: Option[String],
creationDate: Instant,
lastAuthTime: Option[Instant],
userId: Option[UUID]
)
3 changes: 2 additions & 1 deletion app/models/UserSession.scala
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,9 @@ object UserSession {
sealed abstract trait LoginType

object LoginType {
case object MagicLink extends LoginType
case object ProConnect extends LoginType
case object InsecureDemoKey extends LoginType
case object MagicLink extends LoginType
case object Password extends LoginType
}

Expand Down
38 changes: 37 additions & 1 deletion app/modules/AppConfig.scala
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import com.typesafe.config.{Config, ConfigFactory}
import helper.{Crypto, UUIDHelper}
import java.util.UUID
import javax.inject.{Inject, Singleton}
import play.api.Configuration
import play.api.{ConfigLoader, Configuration}
import scala.concurrent.duration._

// Wraps `configuration: play.api.Configuration`.
Expand Down Expand Up @@ -151,4 +151,40 @@ class AppConfig @Inject() (configuration: Configuration) {
.flatMap(UUIDHelper.fromString)
.toSet

val featureProConnectEnabled: Boolean =
configuration.get[Boolean]("app.features.proConnectEnabled")

def proConnectConfig[A: ConfigLoader](key: String, defaultIfDisabled: => A): A =
configuration
.getOptional[A](key)
.getOrElse(
if (featureProConnectEnabled)
throw new Exception(s"Missing ProConnect configuration key $key")
else defaultIfDisabled
)

val proConnectIssuerUri: String =
proConnectConfig[String]("app.proConnect.issuerUri", "")

val proConnectMinimumDurationBetweenDiscoveryCalls: FiniteDuration =
proConnectConfig[Int](
"app.proConnect.minimumDurationBetweenDiscoveryCallsInSeconds",
10
).seconds

val proConnectClientId: String =
proConnectConfig[String]("app.proConnect.clientId", "")

val proConnectClientSecret: String =
proConnectConfig[String]("app.proConnect.clientSecret", "")

val proConnectRedirectUri: String =
proConnectConfig[String]("app.proConnect.redirectUri", "")

val proConnectPostLogoutRedirectUri: String =
proConnectConfig[String]("app.proConnect.postLogoutRedirectUri", "")

val proConnectSigningAlgorithm: String =
proConnectConfig[String]("app.proConnect.signingAlgorithm", "")

}
1 change: 1 addition & 0 deletions app/serializers/Keys.scala
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ object Keys {
val signupId: String = "signupId"
val sessionId: String = "sessionId"
val signupLoginExpiresAt: String = "signupLoginExpiresAt"
val signupProConnectSubject: String = "signupProConnectSubject"
val passwordEmail: String = "passwordEmail"
}

Expand Down
Loading
Loading