Option pour remplacer un ingrédient demandé par un ingrédient existant #1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
This is to cut down on the size of the file as more actions are added
hfroot
force-pushed
the
replace-ingredient-request
branch
from
276a7b6 to
803d024
Compare
This is a simplification of the needs to reduce the scope of the PR
…ing with element of wrong type
…tion summary view
This is an initial simple implementation that needs to be updated to hide alert once recalculation has happened
hfroot
commented
Dec 19, 2024
hfroot
commented
Dec 19, 2024
hfroot
commented
Dec 19, 2024
hfroot
commented
Dec 19, 2024
hfroot
commented
Dec 19, 2024
hfroot
commented
Dec 19, 2024
hfroot
commented
Dec 19, 2024
hfroot
commented
Dec 19, 2024
hfroot
commented
Dec 19, 2024
hfroot
commented
Dec 19, 2024
alemangui
requested changes
Dec 27, 2024
| @@ -1753,3 +1808,46 @@ def test_status_visible_to_instructor(self): | |||
| m = declared_microorganisms[0] | |||
| self.assertIn("requestStatus", m) | |||
| self.assertIn("requestPrivateNotes", m) | |||
|
|
|||
There was a problem hiding this comment.
Est-ce que ça vaut la peine d'ajouter un test sur les permissions pour ces nouveaux endpoints ? Similaire à test_get_declared_element_not_allowed_not_instructor
Co-authored-by: Alejandro M Guillén <[email protected]>
4 tasks
alemangui
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dans le scope : fonctionnalité pour trouver un ingrédient de même type et remplacer une demande avec.
Hors du scope : ajout de synonyme en même temps; remplacement d'une demande par un ingrédient d'autre type (par ex microorganisme avec plante), à faire à la main pour l'instant
Control de la demande
Il y a une explication quand le remplacement est bloqué au cause du type
Quand la demande a été remplacée :
MAJ du badge pour les instructrices
NB: Les déclarants vont voir le nom du remplacement si ils vont regarder la déclaration.
Calculation de substances
Le tableau de substances est déjà automatiquement recalculé. Cette PR ajoute un avertissement au dessus si il y a des remplacements qui ont des substances.
NB: pour l'instant, cet avertissement est toujours affiché pour l'instructrice. Question: est-ce que c'est acceptable en premier temps ?