feat(Validata): Import achats: ajout d'appels à Validata et renvoyer les erreurs #4949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphodn
changed the base branch from
staging
to
raphodn/backend-api-utils-import
raphodn
force-pushed
the
raphodn/backend-api-utils-header-validata
branch
from
16396a7 to
17b25bd
Compare
3 tasks
qloridant
reviewed
Jan 28, 2025
| self.data_schema = json.load(open("data/schemas/imports/achats.json")) | ||
| self.expected_header = [field["name"] for field in self.data_schema["fields"]] | ||
| self.schema_url = ( | ||
| "https://raw.githubusercontent.com/betagouv/ma-cantine/refs/heads/staging/data/schemas/imports/achats.json" |
There was a problem hiding this comment.
On peut aussi en profiter pour refactor la fonction validate en passant le fichier directement
voir code compl'alim
There was a problem hiding this comment.
dans ton exemple le schema est aussi une url il me semble ?
There was a problem hiding this comment.
Oui pardon, j'ai confondu avec le fichier
raphodn
force-pushed
the
raphodn/backend-api-utils-import
branch
from
bb31e03 to
314296d
Compare
raphodn
force-pushed
the
raphodn/backend-api-utils-header-validata
branch
from
8a4f83b to
60764b2
Compare
raphodn
force-pushed
the
raphodn/backend-api-utils-import
branch
3 times, most recently
from
0b86819 to
43b6c1c
Compare
raphodn
commented
Jan 28, 2025
api/views/utils.py
Outdated
| @@ -31,6 +34,45 @@ def _get_file_digest(self): | |||
| file_hash.update(row) | |||
| return file_hash.hexdigest() | |||
|
|
|||
| def _get_file_dialect(self): | |||
There was a problem hiding this comment.
je vais basculer la logique "dialect" dans la PR précédente
There was a problem hiding this comment.
et j'ai basculé la logique header dans une PR séparée
raphodn
force-pushed
the
raphodn/backend-api-utils-header-validata
branch
from
60764b2 to
36b538b
Compare
raphodn
force-pushed
the
raphodn/backend-api-utils-import
branch
3 times, most recently
from
76c1e8e to
6be0241
Compare
raphodn
force-pushed
the
raphodn/backend-api-utils-header-validata
branch
from
36b538b to
9a82b53
Compare
raphodn
force-pushed
the
raphodn/backend-api-utils-header-validata
branch
from
87eb3d6 to
5ef3aa0
Compare
raphodn
force-pushed
the
raphodn/backend-api-utils-header-validata
branch
from
5ef3aa0 to
9dc53a8
Compare
raphodn
changed the base branch from
staging
to
raphodn/backend-api-utils-header-check-purchases
raphodn
force-pushed
the
raphodn/backend-api-utils-header-validata
branch
4 times, most recently
from
b902895 to
e837692
Compare
Base automatically changed from
raphodn/backend-api-utils-header-check-purchases
to
staging
February 4, 2025 12:43
raphodn
force-pushed
the
raphodn/backend-api-utils-header-validata
branch
from
e837692 to
bf22a83
Compare
raphodn
commented
Feb 5, 2025
| return response.json()["report"] | ||
|
|
||
|
|
||
| def process_errors(report): |
There was a problem hiding this comment.
question à trancher : est-ce qu'on pre-process les erreurs Validata ici (dans le backend), ou coté frontend ?
There was a problem hiding this comment.
yes go pour le front ! du coup je renvoi un maximum d'infos dans l'objet
raphodn
force-pushed
the
raphodn/backend-api-utils-header-validata
branch
from
b9210ab to
aac7a7a
Compare
raphodn
had a problem deploying
to
review-apps
GitHub Actions
Failure
raphodn
had a problem deploying
to
review-apps
GitHub Actions
Failure
raphodn
commented
Feb 10, 2025
| # Reset the file pointer to the beginning | ||
| file.seek(0) | ||
| response = requests.post( | ||
| "https://api.validata.etalab.studio/validate", |
There was a problem hiding this comment.
à noter que ca fait des appels API à chaque lancement de tests CI 👀
raphodn
force-pushed
the
raphodn/backend-api-utils-header-validata
branch
from
9699526 to
4b4d446
Compare
raphodn
had a problem deploying
to
review-apps
GitHub Actions
Failure
raphodn
changed the title
raphodn
force-pushed
the
raphodn/backend-api-utils-header-validata
branch
from
4b4d446 to
4a21643
Compare
raphodn
had a problem deploying
to
review-apps
GitHub Actions
Failure
raphodn
changed the title
raphodn
force-pushed
the
raphodn/backend-api-utils-header-validata
branch
from
4a21643 to
c3c174f
Compare
raphodn
had a problem deploying
to
review-apps
GitHub Actions
Failure
Charline-L
approved these changes
Feb 11, 2025
api/tests/test_import_purchases.py
Outdated
There was a problem hiding this comment.
Remarque mais pas bloquant, en fait on aurait aussi pu simplifier les tests en vérifiant le "title" et non "message" ?
There was a problem hiding this comment.
je vois ton message que maintenant, mais en effet maintenant qu'on a le title... je note de corriger
There was a problem hiding this comment.
je vais laisser tel quel, vu que ailleurs (les autres erreurs) on fait les test sur le champ message aussi..
à voir comment on pourra homogénéiser tout ça
raphodn
force-pushed
the
raphodn/backend-api-utils-header-validata
branch
from
c3c174f to
1560e7f
Compare
raphodn
had a problem deploying
to
review-apps
GitHub Actions
Failure
raphodn
had a problem deploying
to
review-apps
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nouveau fichier
common/api/validata.py