[fix] Issue with use of DRF serializers in webhook #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etchegom
changed the title
etchegom
force-pushed
the
fix/webhook-serializers
branch
from
5fa79e3 to
b3ccbeb
Compare
etchegom
force-pushed
the
fix/webhook-serializers
branch
from
b3ccbeb to
21c17fc
Compare
etchegom
commented
Feb 17, 2025
| @@ -36,11 +36,13 @@ def find_webhooks(self, topic: str, instance: Any) -> list[tuple[int, str]]: | |||
| ) | |||
|
|
|||
| def model_dict(self, instance: Any) -> dict[str, Any]: | |||
| kwargs = {"context": {"request": None}} | |||
There was a problem hiding this comment.
Il faut juste qu'un objet request soit présent dans le contexte, même si il est à None.
glibersat
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Il s'agit de :
Décrivez vos changements
J'avais désactivé les champs
_linkdes payloads de l'API, à cause d'une erreur sur la partie webhook, qui utilise les serializers DRF, mais sans contexte.J'ai fait ce fix pour les réactiver, en ajoutant un test coté webhook.
Checklist d'acceptation de revue de code
Demandes