added to_currency function to LiquidJS step #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to_currency added to LiquidJS This is missing in the LiquidJS NPM package Formatting is exactly the same as Classic Gen syntax
Added to_currency function
thomas9911
reviewed
Nov 18, 2024
| ) { | ||
| fractionDigits = fractionDigits || 2; | ||
| decimalSeparator = decimalSeparator || '.'; | ||
| thousandSeparator = thousandSeparator || null; |
There was a problem hiding this comment.
I think you have to do ?? 2 ect otherwise if you fill in 0 it will override it with 2
(I think it is the same as with the '.' and empty string)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to_currency added to LiquidJS
This is missing in the LiquidJS NPM package
Formatting is exactly the same as Classic Gen syntax