-
-
Notifications
You must be signed in to change notification settings - Fork 22
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ask/choose/confirm: complete no-TTY support
/close #253 - shellcheckrc: add `SC2059`, and add docs on all the disabled rules - ask: rewrote for modern conventions, support no-TTY, fix read failures not being output - ask/choose/confirm: consistent commentary styling - choose: fix blockquote line being a different color or breaking colors - confirm: fix and improve the WIP no-TTY support, now complete - dorothy: prompt for lint upgrade before dev deps, to speed up UX - echo-clear-lines: rewrote to support all known edge cases - echo-count-lines: add note that it doesn't wrap - echo-escape-command: use new `__quote` helped in `bash.bash` to support ANSI Escape Codes - echo-quote: add tests, add support for `--single` and `--double` arguments - echo-regexp(.ts)?: better support for character classes, supporting `[[:XXX:]]` and `[:XXX:]` forms - echo-revolving-door: rewrote to support all known edge cases - added `echo-substr`: as command alias for `__substr` helper in `bash.bash` - echo-wrap: fix help errors not showing, support --column=* alias for --width=* - eval-helper: updated for TTY changes, aand fix all known edge cases - expand-path.zsh: same functionality, but rewrote for clarity - setup-util: linting, and only output the output if there is output - setup-util-bash: compact `echo-style` calls for performance, include `setup-util --check` for performance - until-success: rewrote for new TTY conventions - echo-escape-special: fix everything being dumped together - is-shapeshifter: rewrote and add tests, to fix all known edge cases, and now uses `bash.bash` helpers - bash.bash: - remove deprecated usage of `__print_line ...` use `__print_lines ...` instead - support initial `--` argument in appropriate functions - rewrite to use [[ ... ]] instead of test/[ to better handle edge cases - stdinargs.bash: - rewrite to use [[ ... ]] instead of test/[ to better handle edge cases, such as a trailing line containing only `>` - zsh.zsh: - consistency with `bash.bash` changes - rewrote and fixed `__substr` helper for edge cases - added `is_shapeshifter` and `__escape_shapeshifting` helpers, used in `is-shapeshifter` - ansi-escape-codes.md: removed excess docs todos: - decide if ask/choose/confirm linger should be outputted to stderr if there is commentary and a sucess code but no linger, check if consistent with choose - setup-util: consider new wrapper for the font selection too
- Loading branch information
Showing
43 changed files
with
1,271 additions
and
695 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,15 @@ | ||
# https://github.com/trunk-io/configs | ||
enable=all | ||
source-path=SCRIPTDIR | ||
disable=SC2154,SC2164,SC2250,SC2310,SC2249,SC2312,SC1090,SC1091,SC2317,SC2016 | ||
disable=SC2154,SC2164,SC2250,SC2310,SC2249,SC2312,SC1090,SC1091,SC2317,SC2016,SC2059 | ||
# https://www.shellcheck.net/wiki/SC2154 var is referenced but not assigned. | ||
# https://www.shellcheck.net/wiki/SC2164 Use cd ... || exit in case cd fails. | ||
# https://www.shellcheck.net/wiki/SC2250 Prefer putting braces around variable references even when not strictly required. | ||
# https://www.shellcheck.net/wiki/SC2310 This function is invoked in an 'if' condition so set -e will be disabled. Invoke separately if failures should cause the script to exit. | ||
# https://www.shellcheck.net/wiki/SC2249 Consider adding a default *) case, even if it just exits with error. | ||
# https://www.shellcheck.net/wiki/SC2312 Consider invoking this command separately to avoid masking its return value (or use '|| true' to ignore). | ||
# https://www.shellcheck.net/wiki/SC1090 Can't follow non-constant source. Use a directive to specify location | ||
# https://www.shellcheck.net/wiki/SC1091 Not following: (error message here) | ||
# https://www.shellcheck.net/wiki/SC2317 Command appears to be unreachable. Check usage (or ignore if invoked indirectly). | ||
# https://www.shellcheck.net/wiki/SC2016 Expressions don't expand in single quotes, use double quotes for that. | ||
# https://www.shellcheck.net/wiki/SC2059 Don't use variables in the printf format string. Use printf "..%s.." "$foo". |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.