Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add no_std and portable-atomic support #19

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Add no_std and portable-atomic support #19

merged 1 commit into from
Jan 28, 2025

Conversation

bushrat011899
Copy link
Contributor

Objective

  • Add no_std support
  • Add support for atomically challenged platforms using portable-atomic

Solution

  • Ran cargo clippy --fix to resolve minor issues
  • Added std feature and gated the implementations involving Path and PathBuf behind it.
  • Added portable-atomic as a dependency for platforms without atomic pointer support.

Notes

The new std feature constitutes a breaking change, so a version bump will be required.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 28, 2025
Merged via the queue into bevyengine:main with commit a3cd971 Jan 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminBrienen BenjaminBrienen BenjaminBrienen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bushrat011899 @BenjaminBrienen @alice-i-cecile