#3959 Refactored stockpile limits into unit custom params

[ryanbennitt]

Work done

Refactored stockpile limits into each unit's custom params section instead.

Some values remain as cannot find these unit defs here, are they stored elsewhere or are they vestigial and can be removed?

Addresses Issue(s)

Move default stockpile limits to customparams #3959
#3959

Setup

Just a regular game, some units changed require evolved commanders, legion, raptors

Test steps

Construct any unit containing a limited stockpile of e.g. missiles, confirm that it stops building when its stockpile limit is reached

[sprunk]

Looks good. Decoms exist and are defined here:

• https://github.com/beyond-all-reason/Beyond-All-Reason/blob/master/units/other/evocom/armcorevodecom.lua
• https://github.com/beyond-all-reason/Beyond-All-Reason/blob/master/units/Legion/Legion%20EvoCom/legevodecom.lua

[ryanbennitt]

Refactored these too

[WatchTheFort]

Even though it's unchanged, the if statement on lines 46-50 can be fixed.

if ud.customParams and ud.customParams.stockpileLimit then
	isStockpilingUnit[udid] = tonumber(ud.customParams.stockpileLimit)
elseif ud.customParams and ud.customParams.stockpilelimit then
	isStockpilingUnit[udid] = tonumber(ud.customParams.stockpilelimit)
end

Both branches of the if statement are identical. As well, customParams is guaranteed not to be nil, so no nil check is required.

if ud.customParams.stockpileLimit then
	isStockpilingUnit[udid] = tonumber(ud.customParams.stockpileLimit)
end

[ryanbennitt]

Even though it's unchanged, the if statement on lines 46-50 can be fixed.

if ud.customParams and ud.customParams.stockpileLimit then
	isStockpilingUnit[udid] = tonumber(ud.customParams.stockpileLimit)
elseif ud.customParams and ud.customParams.stockpilelimit then
	isStockpilingUnit[udid] = tonumber(ud.customParams.stockpilelimit)
end

Both branches of the if statement are identical. As well, customParams is guaranteed not to be nil, so no nil check is required.

Alas the case is not identical in both branches, the L/l is upper case/lower case. There are some uses in code of the lower case which I could refactor, but any external use of this outside of the repo will not be updated. Is there a deprecation process or should I just proceed?

[ryanbennitt]

There's some scavenger code removed, I'm assuming when scavenger units are created that they copy all the customParams, so they'll have the stockpile limits already.

[sprunk]

Yea scavs copy customparams. Making customparams have consistent case sounds like a separate task, imo keep PRs small and focused

[WatchTheFort]

But the two conditions are identical, only the first branch will ever run, the elseif is no-op.

[sprunk]

no they aren't, the second one checks for lowercase

[sprunk]

[ryanbennitt]

So fix now or later? Actually I can only see three occurrences of lower case l in unitdef_changes.lua, so not a big one to fix and definitely related to this area of code.

[ryanbennitt]

Actually unitdef_changes.lua is all weapon defs, not unit defs, so does stockpilelimit even apply here?