Add tracy.LuaTracyPlot and tracy.LuaTracyPlotConfig
#1651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p2004a
reviewed
Aug 22, 2024
p2004a
reviewed
Aug 22, 2024
sprunk
commented
Aug 23, 2024
| * @string[opt="Number"] plotFormatType "Number"|"Percentage"|"Memory" | ||
| * @bool[opt=true] stepwise stepwise chart | ||
| * @bool[opt=false] fill whether to fill color | ||
| * @number[opt=white] color unit32 number as BGR color |
There was a problem hiding this comment.
In theory "white" is not a valid Lua value, but then 0xFFFFFF isn't either, and all the real ways to actually produce that value from lua are imo too verbose to put here and don't even convey the format well.
sprunk
commented
Aug 23, 2024
Comment on lines
+1836
to
+1837
| Wipe(18 + 7); | ||
| else if (!strncmp(script + 18, "(", 1)) |
There was a problem hiding this comment.
The 18, 7 and 1 are magic but it should be obvious from context what they are, and named constants would be pretty unwieldy.
p2004a
approved these changes
Aug 23, 2024
|
So we close #1215 and merge this one? |
|
Yes, but also @Beherith has never said anything about 1651 while he was the one to request the feature and is the author of 1215. |
|
its stunning, thank you! |
Beherith
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1215 but in the
tracy.namespace, 100% free when not using tracy builds, and no code fromrts/lib/tracy/*was touched so there won't be any issues with updating the lib in the future.