Use memory mapped files access #1781
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sprunk
reviewed
Nov 28, 2024
| std::vector<std::uint8_t> buf; | ||
|
|
||
| if (!ar->GetFile(fileName, buf) || buf.empty()) { | ||
| // use the same buffer to avoid allocation costs for every invocation |
There was a problem hiding this comment.
Perhaps this could be static to the function instead of class member?
sprunk
reviewed
Nov 28, 2024
| #endif | ||
| return false; |
There was a problem hiding this comment.
The non-TOOLS path will have two unconditional returns in a row now, the second one is dead code and may confuse static analysis (or produce warnings etc)
sprunk
reviewed
Nov 28, 2024
| @@ -6,6 +6,7 @@ | |||
| #include <vector> | |||
| #include <string> | |||
| #include <fstream> | |||
| #include <memory> | |||
There was a problem hiding this comment.
Shouldn't this be added to some .cpp file(s) instead? Looks like no new code was added below so probably doesn't need to be in the header (gets applies everywhere the .h is included even if not all .cpp files need it)
|
Please add it as git submodule, not copy paste code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.