-
Notifications
You must be signed in to change notification settings - Fork 946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wasm extension #1204
wasm extension #1204
Conversation
Signed-off-by: xuleiming <[email protected]>
Signed-off-by: xuleiming <[email protected]>
Signed-off-by: xuleiming <[email protected]>
Signed-off-by: xuleiming <[email protected]>
Signed-off-by: xuleiming <[email protected]>
Signed-off-by: xuleiming <[email protected]>
Signed-off-by: xuleiming <[email protected]>
return nil | ||
} | ||
|
||
type PluginConfFile struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
应该切分为独立的文件
return nil | ||
} | ||
|
||
type PluginTable struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
应该切分为独立的文件
bfe_wasmplug/plugin.go
Outdated
return nil, ErrEngineNotFound | ||
} | ||
|
||
// load wasm bytes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line 124 - 155,单独切分一个函数吧
bfe_wasmplug/plugin.go
Outdated
GetRootContextID() int32 | ||
} | ||
|
||
type wasmPluginImpl struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wasmPluginImpl切分为独立文件
bfe_wasmplug/plugin.go
Outdated
} | ||
|
||
if num < w.InstanceNum() { | ||
w.lock.Lock() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line 189 - 199,切分为独立函数
bfe_wasmplug/plugin.go
Outdated
newInstance = append(newInstance, instance) | ||
} | ||
|
||
w.lock.Lock() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line 229 - 234,切分为独立函数
Signed-off-by: xuleiming <[email protected]>
Signed-off-by: xuleiming <[email protected]>
Signed-off-by: xuleiming <[email protected]>
Implement the Proxy-Wasm interface (https://github.com/proxy-wasm).
Can dynamically load and call wasm plugins following the Proxy-Wasm spec (https://github.com/proxy-wasm/spec).