-
-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
b2-engine target should build b2 first #294
base: main
Are you sure you want to change the base?
b2-engine target should build b2 first #294
Conversation
Also fixes stage/install not installing b2.pdb.
There was a reason. I don't remember if it was a good or bad one. I'll need to check the task that generates the Windows installer to see if will break with this change though. |
Isn't there a CI task for that? Which is turned off for PRs... |
Yes there is :-) It's turned off because I intended to add signing of the installer. But that has turned out to be prohibitively expensive. So perhaps it would be turned back on. And I checked.. And yes the installer will need to change. Although it still has most of the changes needed commented out already. |
PS. This is the installer CI https://github.com/bfgroup/b2/blob/main/.github/workflows/installer_windows.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I guess the one big question on this is that we want a release build of b2 engine to be installed by default. Which is what the current behavior does.
I'm confused. You want me to add |
I finally realized the real reason I didn't do this originally.. It means setting up a *-config.jam to be able to install. Which would mean having users go through a manual step to install. |
This does not make sense to me. Lets say I have a system installed b2, I call |
Also fixes stage/install not installing b2.pdb.
Maybe I misunderstood and it installs bootstraped executable for a good reason?