Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue #137 at https://github.com/bg111/asterisk-chan-dongle/issues/137 #209

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

tkmsst
Copy link

@tkmsst tkmsst commented May 10, 2015

At initialization, try 'AT+CPMS="ME","ME","ME"', first.
If fails, switch to 'AT+CPMS="SM","SM","SM"'.

Signed-off-by: sstream [email protected]

At initialization, try 'AT+CPMS="ME","ME","ME"', first.
If fails, switch to 'AT+CPMS="SM","SM","SM"'.

Signed-off-by: sstream <[email protected]>
@bg111
Copy link
Owner

bg111 commented Oct 2, 2016

I make review of this patch.

I think patch not acceptable.

Reasons:

  1. initialization function is global function.
    make changes in initialization sequence will change settings for ALL dongles under chan_dongle control/
    But this changes can be caused by only ONE dongle fails on settings ME as SMS storage.

  2. usage of strcpy() and remove const from string command is dangerous.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants