Add new scenario ПроверкаКорректностиXML #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Добавлен новый сценарий валидации XML-файла без логики
Добавлен новый сценарий ПроверкаДублейУникальныхИдентификаторов для поиска по всей конфигурации одинаковых guid'ов
theshadowco
reviewed
Jun 26, 2024
Comment on lines
+143
to
+149
| Для каждого УИД Из УникальныеИдентификаторы Цикл | ||
|
|
||
| ТекстУИД = СтрШаблон("uuid=""%1", УИД); | ||
| Если СтрНайти(ТекстФайла, ТекстУИД) > 0 Тогда | ||
| Возврат УИД; | ||
| КонецЕсли; | ||
| КонецЦикла; |
There was a problem hiding this comment.
можно проверять регулярным выражением, собрав UID в одну строку через |
| @@ -0,0 +1,79 @@ | |||
| /////////////////////////////////////////////////////////////////////////////// | |||
There was a problem hiding this comment.
Лучше разделить на отдельные реквесты, в каждом свой сценарий
|
Надо добавить тестов для каждого сценария |
Разделить я могу, но по вопросам тестов - я не силен. Всё хочу научиться, но пока не знаю как приступить. |
|
@Kirill |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Добавлен новый сценарий валидации XML-файла без логики